>From Ali Alsuliman <[email protected]>: Attention is currently required from: Murtadha Hubail, Peeyush Gupta, [email protected]. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18401 )
Change subject: [NO ISSUE][COMP] Honor select-list field order ...................................................................... Patch Set 20: (2 comments) File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/ARecordVisitablePointable.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18401/comment/9a37c7fd_8ad00ffc PS19, Line 98: LinkedHashSet<String> allOrderedFields = inputType.getAllOrderedFields(); > For non order queries or queries which contains closed fields > allOrderedFields will be null and we w […] Don't we already have both of them as String? fieldNameStrs and allOrderedFields? We can think about this in a later patch. File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/OpenRecordConstructorResultType.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18401/comment/9c2df83d_d3401dd4 PS19, Line 69: metadataProvider != null > When i tried "select 1;" metadataProvider is null; […] Ack -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18401 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ia6e37080e581b92744ddd9090b291936513c75af Gerrit-Change-Number: 18401 Gerrit-PatchSet: 20 Gerrit-Owner: [email protected] Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: [email protected] Gerrit-Comment-Date: Wed, 25 Sep 2024 22:21:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ali Alsuliman <[email protected]> Comment-In-Reply-To: [email protected] Gerrit-MessageType: comment
