>From Michael Blow <[email protected]>: Attention is currently required from: Murtadha Hubail, Ian Maxon, Hussain Towaileb. Michael Blow has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18786 )
Change subject: [ASTERIXDB-3497][OTH]: Add method to get physical disk size used of given path ...................................................................... Patch Set 8: (1 comment) File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/IoUtil.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18786/comment/8c967073_9bf84f2e PS8, Line 314: boolean isSi = unitString.indexOf('i') != -1; This doesn't work for kilobyte, gigabyte Don't we already have a facility which handles byte units? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18786 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ic7b9605b704889836674f8d62a6c8dea86e7df52 Gerrit-Change-Number: 18786 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-CC: Michael Blow <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Tue, 08 Oct 2024 13:43:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
