>From Murtadha Hubail <[email protected]>: Attention is currently required from: Ian Maxon, Wail Alkowaileet, Ayush Tripathi, Ali Alsuliman. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18708 )
Change subject: [ASTERIXDB-3503][EXT] Deltalake format support ...................................................................... Patch Set 18: Code-Review+2 (4 comments) File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18708/comment/5a12f9f2_9c6cfe19 PS18, Line 101: INVALID_DELTA_PARAMETER This isn't really a generic invalid parameter error. You probably should rename it to INVALID_DELTA_TABLE_FORMAT or something. Also, add a negative test case to test this. File asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18708/comment/be71e420_105c10a7 PS18, Line 44: Type we are calling it "format" in our parameters and not type. Also, if you look a the error codes in this section, they are more of a runtime type errors. In your case, this is more of a compilation error. You should move this to the compile time errors section. Also, we usually put in the message what the user provided as input. Take a look at the examples in the compile errors. File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18708/comment/6d01a3a6_b988526e PS18, Line 476: configuration.get(ExternalDataConstants.TABLE_FORMAT).equals(ExternalDataConstants.FORMAT_DELTA) just use isDeltaTable https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18708/comment/f4b1ae7c_64cb4f66 PS18, Line 501: prepareDeltaTableFormat This class is getting too big. We might want to move code pieces that are related to each other to different util. You don't have to do this now. Just something to keep in mind. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18708 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Iff608397aab711f324861fe83eeb428f73682912 Gerrit-Change-Number: 18708 Gerrit-PatchSet: 18 Gerrit-Owner: Ayush Tripathi <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ayush Tripathi <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Attention: Wail Alkowaileet <[email protected]> Gerrit-Attention: Ayush Tripathi <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Thu, 10 Oct 2024 15:26:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
