>From Murtadha Hubail <[email protected]>: Attention is currently required from: Savyasach Reddy. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18767 )
Change subject: Write to HDFS ...................................................................... Patch Set 18: (7 comments) Commit Message: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18767/comment/0ce67c99_7798bdb5 PS18, Line 7: Write to HDFS please follow the standard commit format. I filed this ticket for t his improvement [ASTERIXDB-3519] File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to-hdfs/parquet-cover-data-types/parquet-cover-data-types.02.update.sqlpp: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18767/comment/47b41c1b_626f3c75 PS18, Line 22: * Date : 7 May 2013 : * Issue : 363 fix or remove File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/HDFSDataSourceFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18767/comment/ee8eb1bd_ae533aa4 PS18, Line 104: Subject subject = new Subject(); : subject.getPrivateCredentials().add(creds); : UserGroupInformation.loginUserFromSubject(subject); This code seems to be repeated multiple times. Refactor if possible File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/HDFSUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18767/comment/89af003a_d8276bc8 PS18, Line 275: configureHadoopAuthentication Can't two requests come here at the same time? If so, then UserGroupInformation seems to be not thread safe. Same thing for System.setProperty. One thread might set it while another is clearing it. Is there some encapsulation can be used without using the system property or what seems to be a static UserGroupInformation? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18767/comment/7fe4fe04_ab1cf31d PS18, Line 295: Krb5LoginModule make it a constant with a proper name https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18767/comment/097cddbb_ef871093 PS18, Line 323: com.sun.security.auth.module.Krb5LoginModule make it a constant with a proper name File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/HDFSExternalFileWriterFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18767/comment/cc7974cc_735fa622 PS18, Line 132: FileSystem testFs = createFileSystem(conf); : doValidate(testFs); : testFs.close(); When something is closable, always try to use try-with-resources. e.g.: try (FileSystem testFs = createFileSystem(conf)) { doValidate(testFs); } -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18767 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ifc4ed9fb17a7540cf444a2f8bef590756b909988 Gerrit-Change-Number: 18767 Gerrit-PatchSet: 18 Gerrit-Owner: Savyasach Reddy <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Murtadha Hubail <[email protected]> Gerrit-Attention: Savyasach Reddy <[email protected]> Gerrit-Comment-Date: Mon, 21 Oct 2024 17:01:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
