>From Peeyush Gupta <[email protected]>: Attention is currently required from: Vijay Sarathy. Peeyush Gupta has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19025 )
Change subject: [ASTERIXDB-3522][COMP] Invalid sample query generated ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinNode.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19025/comment/80dfca0c_fd6052ab PS1, Line 646: selOp = (SelectOperator) joinEnum.getStatsHandle().findSelectOpWithExpr(leafInput, afce); > You can move this to outside the if-else block as this is now common to the > if and the else part. Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19025 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: goldfish Gerrit-Change-Id: I5504e494c72dab692607f26d33839b280c4a3fcc Gerrit-Change-Number: 19025 Gerrit-PatchSet: 4 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-CC: Ali Alsuliman <[email protected]> Gerrit-CC: Vijay Sarathy <[email protected]> Gerrit-Attention: Vijay Sarathy <[email protected]> Gerrit-Comment-Date: Thu, 31 Oct 2024 15:33:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Vijay Sarathy <[email protected]> Gerrit-MessageType: comment
