Steven Jacobs has posted comments on this change. Change subject: Enable Feed Changes to work with BAD project ......................................................................
Patch Set 1: (3 comments) I reorganized things to meet the suggestions. Take a look at the new patchset. https://asterix-gerrit.ics.uci.edu/#/c/1524/1/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveJobNotificationHandler.java File asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveJobNotificationHandler.java: PS1, Line 56: er listener = e > what if there was no listener. this will cause a null pointer exception Done PS1, Line 60: if (event.getEventKind() == Kind.JOB_FINISHED && !listener.isRepeatable() > Let's remove the block completely and the listener can remove itself when n Done PS1, Line 75: removeJob > maybe rename to remove job and listener? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1524 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib62184b67aff564475ef9b58790ff96409195b77 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
