>From Ian Maxon <[email protected]>: Ian Maxon has submitted this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19052 )
Change subject: [NO ISSUE][*DB][TEST] Make Python Exception test more generic ...................................................................... [NO ISSUE][*DB][TEST] Make Python Exception test more generic The expected warning in this test is too specific. Stack trace formats are not stable depending on python runtime. Matching the exception itself is sufficient. Ext-ref: MB-64032 Change-Id: I58546bf69a44465c50001fc5ae90b2e9d7cbe172 Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19052 Reviewed-by: Ian Maxon <[email protected]> Reviewed-by: Hussain Towaileb <[email protected]> Tested-by: Jenkins <[email protected]> --- M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_it_python.xml 1 file changed, 18 insertions(+), 11 deletions(-) Approvals: Ian Maxon: Looks good to me, but someone else must approve Hussain Towaileb: Looks good to me, approved Jenkins: Verified Anon. E. Moose #1000171: diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_it_python.xml b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_it_python.xml index 50795b7..7b92376 100644 --- a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_it_python.xml +++ b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_it_python.xml @@ -49,22 +49,12 @@ <output-dir compare="Clean-JSON">python_open_type_validation</output-dir> </compilation-unit> </test-case> - <!-- TODO(Ian): disabling this test as it is intermittently failing as the output is dependent on the python version running on the test machine <test-case FilePath="external-library" check-warnings="true"> <compilation-unit name="py_function_error"> <output-dir compare="Clean-JSON">py_function_error</output-dir> - <expected-warn>ASX0201: External UDF returned exception. Returned exception was: Traceback (most recent call last): - File "entrypoint.py", line 181, in handle_call - result[0].append(self.next_tuple(*arg, key=self.mid)) - File "entrypoint.py", line 99, in next_tuple - return self.wrapped_fns[key](*args) - File "site-packages/roundtrip.py", line 32, in warning - raise ArithmeticError("oof") -ArithmeticError: oof - (in line 28, at column 1)</expected-warn> + <expected-warn>ArithmeticError: oof</expected-warn> </compilation-unit> </test-case> - --> <test-case FilePath="external-library"> <compilation-unit name="mysentiment_twitter"> <output-dir compare="Text">mysentiment_twitter</output-dir> -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19052 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: neo Gerrit-Change-Id: I58546bf69a44465c50001fc5ae90b2e9d7cbe172 Gerrit-Change-Number: 19052 Gerrit-PatchSet: 2 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-MessageType: merged
