>From Ayush Tripathi <[email protected]>: Attention is currently required from: Ali Alsuliman. Ayush Tripathi has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19045 )
Change subject: [ASTERIXDB-3525][COMP] Rewrite Like operator with % suffix as AND Operator ...................................................................... Patch Set 16: (10 comments) Commit Message: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19045/comment/989a92e2_7b017f66 PS7, Line 7: Rewrite Like operator with % suffix as AND Operator. > Change the title to: […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19045/comment/dd4bcc70_ae0e0996 PS7, Line 16: Change-Id: I22a4a5b94c89ae8f7132b52848cfe300f09b1645 > Add Ext-ref: MB-XXXX after the Details. Done File asterixdb/asterix-app/src/test/resources/runtimets/sqlpp_queries.xml: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19045/comment/b3af2500_831d1a86 PS7, Line 9996: <compilation-unit name="q02"> > Place this new test under > "src/test/resources/runtimets/queries_sqlpp/index-selection". […] Done File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/OperatorExpressionVisitor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19045/comment/606b8e7e_29a6faa9 PS7, Line 86: createANDExpressionHelper > Name this 'createRangeExpression' and move this method to the bottom of the > file. […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19045/comment/12cdd829_d70f764c PS7, Line 110: value > Name this 'patternExpr'. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19045/comment/2dba2dd9_e5dd56d6 PS7, Line 111: s > First, name this 'patternStr'. […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19045/comment/a123bfde_fbd7c970 PS7, Line 118: "%" > Define a class "ConstantUtil" in "org.apache.asterix.common.utils" and place > the "%" and "_" there. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19045/comment/2e1b5e3a_c1358c68 PS7, Line 119: withoutSuffix > Name this 'prefix'. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19045/comment/9f96e154_57bc1103 PS7, Line 123: result > Name this 'incrementedStr' Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19045/comment/6e65fb9e_5c050134 PS7, Line 126: createANDExpressionHelper(target, left, right, operatorExpr); > Isn't this going to use GE and LE when we want GE and LT? You need to add a > test case to cover this […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19045 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I22a4a5b94c89ae8f7132b52848cfe300f09b1645 Gerrit-Change-Number: 19045 Gerrit-PatchSet: 16 Gerrit-Owner: Ayush Tripathi <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ayush Tripathi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Murtadha Hubail <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Fri, 08 Nov 2024 00:53:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ali Alsuliman <[email protected]> Gerrit-MessageType: comment
