>From Murtadha Hubail <[email protected]>: Attention is currently required from: Peeyush Gupta, Ayush Tripathi, Ali Alsuliman, Murtadha Makki Al Hubail. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19085 )
Change subject: [ASTERIXDB-3503][EXT] Add column filter for Delta Reader. ...................................................................... Patch Set 7: Code-Review+2 (4 comments) Patchset: PS7: Please address the comment on a follow on patch File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/aws/delta/AsterixTypeToDeltaTypeVisitor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19085/comment/ff0fe600_ab51c06f PS7, Line 127: RuntimeException This will mask the error. We should expose the issue here to the user File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/aws/delta/AwsS3DeltaReaderFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19085/comment/e14247b3_c59ced82 PS7, Line 144: warningCollector.shouldWarn() remove this since this changes every time we add a warning File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19085/comment/74176139_fddee679 PS7, Line 924: Parquet /delta -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19085 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: goldfish Gerrit-Change-Id: I809c692777349025d5ce0435c3a6068d432cd282 Gerrit-Change-Number: 19085 Gerrit-PatchSet: 7 Gerrit-Owner: Ayush Tripathi <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Murtadha Makki Al Hubail <[email protected]> Gerrit-CC: Peeyush Gupta <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Ayush Tripathi <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Murtadha Makki Al Hubail <[email protected]> Gerrit-Comment-Date: Tue, 19 Nov 2024 16:52:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
