>From Ritik Raj <[email protected]>: Attention is currently required from: Murtadha Hubail, Peeyush Gupta, Michael Blow. Ritik Raj has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19224 )
Change subject: [ASTERIXDB-3539][STO] Failure to evaluate filter in case of antimatter ...................................................................... Patch Set 5: (3 comments) Commit Message: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19224/comment/e9223186_ed53e6cf PS4, Line 11: no > yes Done File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree-column/src/main/java/org/apache/hyracks/storage/am/lsm/btree/column/api/IColumnTupleIterator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19224/comment/bcdb0c64_02e33015 PS4, Line 112: /** : * When skipping entries which are deleted, skip the entries till last read Index : * @return : */ > This isn't right. This should describe the value returned by this getter. Done File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree-column/src/main/java/org/apache/hyracks/storage/am/lsm/btree/column/impls/lsm/LSMColumnBTreeRangeSearchCursor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19224/comment/72b60e92_48490b38 PS4, Line 90: columnTuple.resetAntiMatterGap(); > In here, it doesn't mark any difference, but it's more logical to do the > reset after the skip call Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19224 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: stabilization-1cffa2bc98 Gerrit-Change-Id: If1afb009ba5c9ca076bdb2dee1cdf332c2f2df59 Gerrit-Change-Number: 19224 Gerrit-PatchSet: 5 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Ritik Raj <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Comment-Date: Tue, 24 Dec 2024 15:42:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Murtadha Hubail <[email protected]> Gerrit-MessageType: comment
