Michael Blow has submitted this change and it was merged. Change subject: Fix Race Condition in Hyracks/AlgebricksException ......................................................................
Fix Race Condition in Hyracks/AlgebricksException Instantiation of message must be synchronized Change-Id: I2879e293af78ec54b3201a748981c32faa481f1a Reviewed-on: https://asterix-gerrit.ics.uci.edu/1515 Sonar-Qube: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> Reviewed-by: Till Westmann <[email protected]> --- M hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksException.java 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Till Westmann: Looks good to me, approved Jenkins: Verified; No violations found; Verified Objections: Jenkins: Violations found diff --git a/hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java b/hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java index 774c4d9..b1f0892 100644 --- a/hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java +++ b/hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java @@ -122,7 +122,9 @@ @Override public String getMessage() { if (msgCache == null) { - msgCache = ErrorMessageUtil.formatMessage(component, errorCode, super.getMessage(), params); + synchronized (this) { + msgCache = ErrorMessageUtil.formatMessage(component, errorCode, super.getMessage(), params); + } } return msgCache; } diff --git a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksException.java b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksException.java index 5d13212..559468d 100644 --- a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksException.java +++ b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksException.java @@ -129,7 +129,9 @@ @Override public String getMessage() { if (msgCache == null) { - msgCache = ErrorMessageUtil.formatMessage(component, errorCode, super.getMessage(), params); + synchronized (this) { + msgCache = ErrorMessageUtil.formatMessage(component, errorCode, super.getMessage(), params); + } } return msgCache; } -- To view, visit https://asterix-gerrit.ics.uci.edu/1515 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2879e293af78ec54b3201a748981c32faa481f1a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]>
