>From Hussain Towaileb <[email protected]>: Attention is currently required from: Michael Blow. Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19344 )
Change subject: [ASTERIXDB-3514][EXT]: Add error codes for missing invalid/missing creds to assume role ...................................................................... Patch Set 8: Code-Review+1 (1 comment) File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/external/IExternalCredentialsCache.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19344/comment/7ff8a5fe_4eb8e928 PS7, Line 74: getName(Map<String, String> configuration) throws CompilationException; : : /** : * Returns the name of the entity which the cached credentials belong to : * : * @param fqn fully qualified name for the credentials entity : * @return name of entity which credentials belong to : */ : String getName(IFullyQualifiedName fqn) throws CompilationException; > These two APIs don't belong in this interface. […] As discussed, will address in a follow up patch. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19344 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I3ea48cc83d4c0b92d66e518f7e8108050f0e553a Gerrit-Change-Number: 19344 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Comment-Date: Fri, 24 Jan 2025 16:23:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Murtadha Hubail <[email protected]> Gerrit-MessageType: comment
