>From Hussain Towaileb <[email protected]>: Attention is currently required from: Murtadha Hubail, Michael Blow. Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19365 )
Change subject: [ASTERIXDB-3514][EXT]: Pass entity-id for all creds required operations ...................................................................... Patch Set 4: (4 comments) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19365/comment/f526d41e_cca8b9a3 PS3, Line 1034: metadataProvider.setExternalEntityIdFromParts(properties, databaseName, dataverseName, datasetName); No dataset exists when creating a new external collection, but we still access S3 to report whether there is anything to read or warn in the result, so we use the parts to uniquely create the entity-id https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19365/comment/523f6089_c91f9bf2 PS3, Line 4053: metadataProvider.setExternalEntityId(properties, dataset); Set the entity-id for the COPY FROM operation. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19365/comment/930f6f29_6fd0dd71 PS3, Line 4155: metadataProvider.setExternalEntityId(properties, dataset); Set the entity-id for COPY TO operation https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19365/comment/8bc630fa_c75e01ea PS3, Line 5829: properties.put(ExternalDataConstants.KEY_EXTERNAL_SOURCE_TYPE, adapterName); Ensure the type property is set for COPY TO statement, like other statements. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19365 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: If5bd9ed7c1fc0aedba7f7bb90acb48c2edf3d580 Gerrit-Change-Number: 19365 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Comment-Date: Wed, 29 Jan 2025 14:19:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
