>From Ian Maxon <[email protected]>: Attention is currently required from: Murtadha Hubail, Peeyush Gupta. Ian Maxon has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18774 )
Change subject: [ASTERIXDB-3495] Library Cloud Storage ...................................................................... Patch Set 13: (7 comments) File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NCUdfApiServlet.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18774/comment/e198f2df_29c1bb37 PS5, Line 234: iomgr > this name sucks, pick a better one Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18774/comment/02d0783d_73df05bc PS5, Line 235: "lib.zip" > make this a final static var Done File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/LibraryDeployPrepareOperatorDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18774/comment/720f9d8e_11f5515e PS5, Line 85: iomgr > this name sucks too Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18774/comment/15bf61c2_9ca10a10 PS5, Line 85: iomgr > this name sucks too Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18774/comment/2f9385b9_f67a539e PS5, Line 88: "lib.zip" > make this a static final var Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18774/comment/55982143_cc6c5a3a PS5, Line 90: "entrypoint.py > " Done File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18774/comment/5f70b48b_c0b9dbba PS5, Line 66: LOGGER.trace > revert Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18774 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I2c173fbdc985ea590da5315c1ce18e7610fb6af0 Gerrit-Change-Number: 18774 Gerrit-PatchSet: 13 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Comment-Date: Wed, 05 Feb 2025 20:37:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ian Maxon <[email protected]> Gerrit-MessageType: comment
