>From <[email protected]>: Attention is currently required from: Peeyush Gupta, Ali Alsuliman, Vijay Sarathy. [email protected] has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19383 )
Change subject: [ASTERIXDB-3555][COMP] Use Join Samples to get Join Selectivity ...................................................................... Patch Set 9: (2 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/Stats.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19383/comment/f327b916_a5366d95 PS5, Line 262: joinEnum.allJoinOps.get(0); > Don't you need the "right" join operator? meaning if the join condition is > coming from an INNER JOIN […] Yes, you are right. I need to pick an inner join only. If a query has only outer joins, I will get a wrong estimate... Tricky. This is not going to be easy to fix IMO because there is no set operator routine. But the rest of the cardinality estimation code also does not make this distinction. We an revisit this later if this becomes an issue. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19383/comment/372cfe1d_630b8c57 PS5, Line 265: abjoin.getInputs().get(0) > It does not seem that this join operator is a copy. […] When the final plan is generated, the same join nodes will be used again. So what I do in the mean time before the final plan is generated wont matter at all. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19383 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I863dc378d5ead9f8b48f09f7bc400f5bdaba4839 Gerrit-Change-Number: 19383 Gerrit-PatchSet: 9 Gerrit-Owner: [email protected] Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Vijay Sarathy <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Vijay Sarathy <[email protected]> Gerrit-Comment-Date: Mon, 10 Feb 2025 18:39:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ali Alsuliman <[email protected]> Comment-In-Reply-To: [email protected] Gerrit-MessageType: comment
