>From Hussain Towaileb <[email protected]>:

Attention is currently required from: Hussain Towaileb, Ali Alsuliman, 
[email protected].
Hussain Towaileb has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19408 )

Change subject: [ASTERIXDB-3392] Support empty spaces, "=" in field names in 
COPY TO parquet
......................................................................


Patch Set 2:

(4 comments)

Patchset:

PS2:
All minor comments, can be addressed another time


File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/ParquetExternalFilePrinter.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19408/comment/d2ade43a_699670c1
PS2, Line 43: //    private String parquetSchemaString;
Remove


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19408/comment/039b383f_be911095
PS2, Line 49: parquetSchemaString
Rename to schema


File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/ParquetExternalFilePrinterFactory.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19408/comment/7048b794_61d45e7f
PS2, Line 35: parquetInferSchema
parquetInferredSchema



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19408
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I9dd788909512bf18cb8de26a78a0787e15b11492
Gerrit-Change-Number: 19408
Gerrit-PatchSet: 2
Gerrit-Owner: [email protected]
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-CC: Hussain Towaileb <[email protected]>
Gerrit-Attention: Hussain Towaileb <[email protected]>
Gerrit-Attention: Ali Alsuliman <[email protected]>
Gerrit-Attention: [email protected]
Gerrit-Comment-Date: Wed, 12 Feb 2025 11:10:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to