>From Hussain Towaileb <[email protected]>: Attention is currently required from: Utsav Singh. Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19405 )
Change subject: [ASTERIXDB-3509]: COPY TO CSV | Raise Warning when TYPE Schema Mismatch ...................................................................... Patch Set 4: (5 comments) Patchset: PS4: Please add test cases to test the warnings as well, thanks. File asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19405/comment/a412c66c_5126d19f PS4, Line 325: Type Schema does not match with the expected output schema. Maybe: record schema does not match the expected output schema? Or record schema does not match the provided schema? Is it clear from Type Schema vs Expected Output Schema? File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19405/comment/c985370b_c9ef41c7 PS4, Line 792: JobGenContext context Do you need the context here? Can't you pass the IWarningCollector directly? File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/metadata/IMetadataProvider.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19405/comment/cfc7971f_638befc1 PS4, Line 66: JobGenContext context IWarningCollector File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/SinkWritePOperator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19405/comment/1d764884_ed4a9105 PS4, Line 179: context context.getWarningCollector() -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19405 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I71d9e315be78a246bba733ea704f2d50ae71507c Gerrit-Change-Number: 19405 Gerrit-PatchSet: 4 Gerrit-Owner: Utsav Singh <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Attention: Utsav Singh <[email protected]> Gerrit-Comment-Date: Thu, 13 Feb 2025 10:35:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
