>From Hussain Towaileb <[email protected]>: Hussain Towaileb has submitted this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19414 )
Change subject: [ASTERIXDB-3392] Minor formatting COPY TO parquet ...................................................................... [ASTERIXDB-3392] Minor formatting COPY TO parquet - user model changes: no - storage format changes: no - interface changes: no Ext-ref: MB-65167 Change-Id: I009fc9e2d4e6cde0f4469b0e6979bf625eae7576 Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19414 Integration-Tests: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Reviewed-by: <[email protected]> Reviewed-by: Hussain Towaileb <[email protected]> --- M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/ParquetExternalFilePrinter.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/ParquetExternalFilePrinterFactory.java 2 files changed, 28 insertions(+), 10 deletions(-) Approvals: Hussain Towaileb: Looks good to me, approved [email protected]: Looks good to me, but someone else must approve Jenkins: Verified; Verified Objections: Anon. E. Moose #1000171: Violations found diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/ParquetExternalFilePrinter.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/ParquetExternalFilePrinter.java index 046c03f..2f95b3e 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/ParquetExternalFilePrinter.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/ParquetExternalFilePrinter.java @@ -40,16 +40,15 @@ private final CompressionCodecName compressionCodecName; private final MessageType schema; private ParquetOutputFile parquetOutputFile; - // private String parquetSchemaString; private ParquetWriter<IValueReference> writer; private final long rowGroupSize; private final int pageSize; private final ParquetProperties.WriterVersion writerVersion; - public ParquetExternalFilePrinter(CompressionCodecName compressionCodecName, MessageType parquetSchemaString, - IAType typeInfo, long rowGroupSize, int pageSize, ParquetProperties.WriterVersion writerVersion) { + public ParquetExternalFilePrinter(CompressionCodecName compressionCodecName, MessageType schema, IAType typeInfo, + long rowGroupSize, int pageSize, ParquetProperties.WriterVersion writerVersion) { this.compressionCodecName = compressionCodecName; - this.schema = parquetSchemaString; + this.schema = schema; this.typeInfo = typeInfo; this.rowGroupSize = rowGroupSize; this.pageSize = pageSize; diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/ParquetExternalFilePrinterFactory.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/ParquetExternalFilePrinterFactory.java index 035e49a..d93decd 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/ParquetExternalFilePrinterFactory.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/ParquetExternalFilePrinterFactory.java @@ -30,9 +30,9 @@ public class ParquetExternalFilePrinterFactory implements IExternalPrinterFactory { private static final long serialVersionUID = 8971234908711235L; - // parquetInferSchema is for the case when the schema is inferred from the data, not provided by the user + // parquetInferredSchema is for the case when the schema is inferred from the data, not provided by the user // set During the runtime - private transient MessageType parquetInferSchema; + private transient MessageType parquetInferredSchema; // parquetProvidedSchema is for the case when the schema is provided by the user private ARecordType parquetProvidedSchema; private final IAType typeInfo; @@ -61,14 +61,14 @@ this.writerVersion = writerVersion; } - public void setParquetSchema(MessageType parquetInferSchema) { - this.parquetInferSchema = parquetInferSchema; + public void setParquetSchema(MessageType parquetInferredSchema) { + this.parquetInferredSchema = parquetInferredSchema; } @Override public IExternalPrinter createPrinter() { - if (parquetInferSchema != null) { - return new ParquetExternalFilePrinter(compressionCodecName, parquetInferSchema, typeInfo, rowGroupSize, + if (parquetInferredSchema != null) { + return new ParquetExternalFilePrinter(compressionCodecName, parquetInferredSchema, typeInfo, rowGroupSize, pageSize, writerVersion); } -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19414 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I009fc9e2d4e6cde0f4469b0e6979bf625eae7576 Gerrit-Change-Number: 19414 Gerrit-PatchSet: 2 Gerrit-Owner: [email protected] Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-MessageType: merged
