>From Peeyush Gupta <[email protected]>: Attention is currently required from: Murtadha Hubail, Ian Maxon, Ritik Raj. Peeyush Gupta has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18774 )
Change subject: [ASTERIXDB-3495] Library Cloud Storage ...................................................................... Patch Set 16: (2 comments) File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/AbstractCloudIOManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18774/comment/e405e732_c134067c PS16, Line 198: public void downloadAllLibraries() throws HyracksDataException { : IParallelDownloader downloader = cloudClient.createParallelDownloader(bucket, localIoManager); : FileReference appDir = resolveAbsolutePath( : localIoManager.getWorkspacePath(0).getPath() + File.separator + APPLICATION_ROOT_DIR_NAME); : LOGGER.info("Downloading all libraries in + {}", appDir); : downloader.downloadDirectories(Collections.singletonList(appDir)); : LOGGER.info("Finished downloading all libraries"); : } : Can the library files be large? If yes, then wouldn't it better to download them lazily if the lazy mode is set to true. File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/LibraryDeployPrepareOperatorDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18774/comment/d2d73eb1_42aa9a4c PS16, Line 81: cloudIoManager.downloadLibrary(Collections.singletonList(libDir)); Aren't we downloading all libraries at bootstrap? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18774 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I2c173fbdc985ea590da5315c1ce18e7610fb6af0 Gerrit-Change-Number: 18774 Gerrit-PatchSet: 16 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Ritik Raj <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Attention: Ritik Raj <[email protected]> Gerrit-Comment-Date: Thu, 13 Feb 2025 21:41:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
