>From Ritik Raj <[email protected]>: Attention is currently required from: Ali Alsuliman, Savyasach Reddy. Ritik Raj has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19187 )
Change subject: [NO ISSUE]: Avoid halts on IO operations failures ...................................................................... Patch Set 23: (1 comment) File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexBulkLoadOperatorNodePushable.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19187/comment/028e4939_b73a2a94 PS23, Line 162: HyracksDataException failure = null; : for (IIndexBulkLoader bulkLoader : bulkLoaders) { : // Let all bulk loaders end : try { : // bulkloader can be null if an exception is thrown before it is initialized. : if (bulkLoader != null) { : bulkLoader.end(); : } : } catch (HyracksDataException e) { : failure = e; : } : } : if (failure != null) { : throw failure; : } should we not abort the rest of the bulkloaders when the first bulkloader fails? otherwise the other bulkLoaders will do unnecessary writes. eg: In columnar with static partitioning, each compute partition can be owner of more than one storage partitions, so in worst case if the first bulkloader itself fails, it will do unnecessary writes to cloud and disk. in my opinion, we should abort the rest of the bulkloaders. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19187 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: If253ea03f5baecbab226e527abb4267670a4233e Gerrit-Change-Number: 19187 Gerrit-PatchSet: 23 Gerrit-Owner: Savyasach Reddy <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Ritik Raj <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Savyasach Reddy <[email protected]> Gerrit-Comment-Date: Mon, 17 Feb 2025 13:56:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
