>From Ian Maxon <[email protected]>: Attention is currently required from: Michael Blow. Ian Maxon has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19452 )
Change subject: [ASTERIXDB-3569][TEST] Reorganize and clean tests ...................................................................... Patch Set 12: (3 comments) File asterixdb/asterix-benchmark/pom.xml: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19452/comment/ac3e219c_f472d0aa PS12, Line 51: <plugin> : <groupId>org.apache.maven.plugins</groupId> : <artifactId>maven-surefire-plugin</artifactId> : <configuration> : <failIfNoTests>false</failIfNoTests> : </configuration> : </plugin> > OOC- did we consider just omitting the surefire plugin from projects that > don't have any tests? unfortunately you can't do this for projects that end up with jar/war/ejb packaging because the default maven lifecycle binds surefire to the test phase File asterixdb/pom.xml: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19452/comment/4d6cae03_f3b03e10 PS12, Line 653: : <includes> : <include>${itest.includes}</include> : </includes> : <excludes> : <exclude>${itest.excludes}</exclude> : </excludes> > in the future, should we refactor this to just specify these > includes/excludes in the projects that […] yeah definitely. it will thin out the main pom a lot. most of this stuff that's coming in here is for the CI profiles in asterix-app. File hyracks-fullstack/pom.xml: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19452/comment/94429cd2_f1d809fc PS12, Line 844: <includes> : <include>${test.includes}</include> : </includes> : <excludes combine.children="append"> : <exclude>${test.excludes}</exclude> : </excludes> > same as mentioned previously same comment would apply then i guess -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19452 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: trinity Gerrit-Change-Id: I9ba2ce7afc54ddd08f5e522627c56e22f51c21d1 Gerrit-Change-Number: 19452 Gerrit-PatchSet: 12 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Comment-Date: Wed, 26 Feb 2025 17:07:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Blow <[email protected]> Gerrit-MessageType: comment
