>From Peeyush Gupta <[email protected]>: Attention is currently required from: Murtadha Hubail, Ali Alsuliman, [email protected]. Peeyush Gupta has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19524 )
Change subject: [ASTERIXDB-3580][COMP] Change collection delivered partitioning property ...................................................................... Patch Set 2: Code-Review+2 (2 comments) File asterixdb/asterix-app/src/test/resources/runtimets/results/join/hash-join-with-redundant-variable/hash-join-with-redundant-variable.14.plan: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19524/comment/750777cf_dffe39b0 PS2, Line 46: [$$55] Not related to this patch, but even if the collection is delivering random partition property, the functional dependency $55->$66 still holds and hash partitioning over just $55 should be enough. File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DataSourcePartitioningProvider.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19524/comment/bd6bc457_658537f1 PS2, Line 160: UnorderedPartitionedProperty.of(pvars, domain); Can this use partitionsMap as well? BucketDataSourcePropertiesProvider.computeDeliveredProperties seems to call getFeedPartitioningProperty function. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19524 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I38ecaccf133028ff8c4854a02c635b44bdcefcc8 Gerrit-Change-Number: 19524 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: [email protected] Gerrit-Comment-Date: Tue, 18 Mar 2025 05:10:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
