>From Ali Alsuliman <[email protected]>: Attention is currently required from: Murtadha Hubail, Peeyush Gupta. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19527 )
Change subject: [ASTERIXDB-3576][EXT] push predicates down to delta tables to filter row groups ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/aws/delta/PredicateSerDe.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19527/comment/88f56e0b_adeadb0c PS3, Line 43: Map<String, Object> expressionObject = visitExpression(expression); : try { : return OBJECT_MAPPER.writeValueAsString(expressionObject); : } catch (JsonProcessingException e) { : throw new RuntimeException(e); : } It might be hard to get into cases where exceptions can be thrown by these, but we can catch them and return null. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19527 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I9fa1a84d7be63ada7b9768a81984b2172e7401b3 Gerrit-Change-Number: 19527 Gerrit-PatchSet: 3 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Comment-Date: Tue, 18 Mar 2025 23:38:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
