>From Ritik Raj <[email protected]>: Attention is currently required from: Murtadha Hubail. Ritik Raj has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19484 )
Change subject: [ASTERIXDB-3574][STO] Taking resource-level lock instead of global lock ...................................................................... Patch Set 10: (11 comments) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19484/comment/aa16aa09_17428f5d PS9, Line 362: datasetLifecycleManager > index = Done File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetInfo.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19484/comment/a2cba240_09631e41 PS9, Line 205: // order of indexes does not matter. so it's fine. > Remove Done File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19484/comment/4c276e12_e026f4d3 PS9, Line 317: LOGGER.log(Level.INFO, "Dropping index " + resourcePath + " on node " + serviceCtx.getNodeId()); > use placeholders Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19484/comment/e6c1b7d9_81e739c0 PS9, Line 345: // Validate dataset lifecycle manager state before proceeding > remove Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19484/comment/4d40b536_36608d89 PS9, Line 456: // no need to validate lifecycle manager state, as being called from the register() > remove Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19484/comment/55f2e4a7_99e2fd42 PS9, Line 532: // No need of synchronization as the "datasets" is concurrentHashMap > remove or put it closest to its usage Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19484/comment/172ec73c_5db61266 PS9, Line 909: // the datasets view is weakly consistent. > same as previous comment Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19484/comment/16afd811_872ab8fd PS9, Line 922: // the datasets view is weakly consistent. : // but since called during startup, things can be considered fine. > same Done File asterixdb/asterix-common/src/test/java/org/apache/asterix/common/context/DatasetLifecycleManagerConcurrentTest.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19484/comment/7678c179_ea7c08fc PS9, Line 96: > remove Done File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/PersistentLocalResourceRepository.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19484/comment/41a2a645_11ed413d PS9, Line 142: beforeWriteAccess(); : try { : resource = resourceCache.getIfPresent(relativePath); : if (resource != null) { : return resource; : } : } finally { : afterWriteAccess(); : } > maybe refactor this to something like getFromCache Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19484/comment/79a2f54e_c8931cfa PS9, Line 151: // since the resource was not present, take a write lock. : // as it involves disk or network I/O, should be done once. > remove or reword Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19484 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I9e3b931b363f082f0a7c69a0454adfd37937bb60 Gerrit-Change-Number: 19484 Gerrit-PatchSet: 10 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ritik Raj <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Comment-Date: Wed, 19 Mar 2025 17:24:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Murtadha Hubail <[email protected]> Gerrit-MessageType: comment
