>From Ali Alsuliman <[email protected]>: Attention is currently required from: Peeyush Gupta, Ritik Raj. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19532 )
Change subject: [ASTERIXDB-3582][COMP] Fix expected schema tree generation ...................................................................... Patch Set 1: (4 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/pushdown/schema/ExpectedSchemaBuilder.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19532/comment/21ab5bb9_f0c8d8d6 PS1, Line 70: producedVar != null If the (new) actual node is different from oldNode, it must be the case that producedVar is not null, right? Just checking. File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/pushdown/schema/ObjectExpectedSchemaNode.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19532/comment/c947ffd5_e9e65aaf PS1, Line 105: typeEnv Do we need the typeEnv as part of the method signature? It seems that you can refactor getChildFieldName() to be getChildFieldName(AbstractFunctionCallExpression parentExpr), then call it and get the field name. File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/pushdown/schema/RootExpectedSchemaNode.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19532/comment/a7f542be_420ce04e PS1, Line 38: ROOT_EXPECTED_SCHEMA_NODES For a simple case like this, I think a boolean method isExpectedRootNode(IExpectedSchemaNode n) or something should be enough. File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/filter/ASTERIXDB-3582-2/ASTERIXDB-3582-2.006.query.sqlpp: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19532/comment/f82ed956_a31a4837 PS1, Line 20: -- there was issue in expected schema tree generation for i and li.qty Can you test with UNION ALL also? just checking if there is anything to take into account since it's treated in a special way. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19532 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: Ic04a618c7aa182af4b1f4b7ade64d687147ef705 Gerrit-Change-Number: 19532 Gerrit-PatchSet: 1 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Ritik Raj <[email protected]> Gerrit-Comment-Date: Thu, 20 Mar 2025 00:40:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
