>From Ali Alsuliman <[email protected]>: Attention is currently required from: Murtadha Hubail, Peeyush Gupta. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19504 )
Change subject: [ASTERIXDB-3575][EXT] Pushdown predicates for Parquet external datasets to filter row groups ...................................................................... Patch Set 5: (4 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/pushdown/processor/ParquetFilterPushdownProcessor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19504/comment/4e572068_95b7034b PS5, Line 77: } Do we need to do scanDefineDescriptor.getFilterPaths().putAll(paths)? I haven't checked what this does, but just saw it's used else where. File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/filter/ParquetFilterBuilder.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19504/comment/4b9f01d4_9b9c8fe1 PS5, Line 135: funcExpr.getArguments().size() != 2 Do we need to do something like we did for delta? or no need? File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/projection/ParquetExternalDatasetProjectionFiltrationInfo.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19504/comment/d3b1f840_eb95edea PS5, Line 27: ExternalDatasetProjectionFiltrationInfo Don't we need to implement some of the methods like: equals() substituteFilterVariable() createCopy() https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19504/comment/3beae5d2_ae6238a3 PS5, Line 50: public void print(AlgebricksStringBuilderWriter writer) We also need the other print for the Json plan: public void print(JsonGenerator generator) -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19504 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I2c3214e2a351252fb1929aa1562cbab2d67fa9aa Gerrit-Change-Number: 19504 Gerrit-PatchSet: 5 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Comment-Date: Fri, 21 Mar 2025 01:46:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
