>From Michael Blow <[email protected]>: Attention is currently required from: Hussain Towaileb. Michael Blow has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19546 )
Change subject: [NO ISSUE]: do not lose cause exceptions and interrupts ...................................................................... Patch Set 1: (5 comments) File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NCQueryServiceServlet.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19546/comment/095937c1_2795ec2b PS1, Line 103: RuntimeDataException hde = RuntimeDataException.create(ErrorCode.REQUEST_TIMEOUT, exception); I don't think we need to preserve the cause here- ErrorCode.REQUEST_TIMEOUT already indicates that we timed out (which is only due to a TimeoutException) File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceRequestParameters.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19546/comment/6b6e6097_e8126965 PS1, Line 604: e We do not need to preserve the cause here- it should be determinable from the value which we are including in the failure message it appears. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19546/comment/586bb4f4_f5f075db PS1, Line 617: e We do not need to preserve the cause here- it should be determinable from the value which we are including in the failure message it appears. File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19546/comment/62e5198d_ac7c7a17 PS1, Line 4892: Thread.currentThread().interrupt(); I'd be curious to add a check here to see if the thread is already interrupted- if `!(e instanceof InterruptedException) && !Thread.currentThread().isInterrupted()` we should log a warning and include the exception (e) in it, since that means something under us lost the interrupt. File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/aws/AwsS3InputStream.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19546/comment/bcbcf31e_a3cb59e4 PS1, Line 104: Thread.currentThread().interrupt(); this is redundant and should be removed -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19546 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: trinity Gerrit-Change-Id: I2cca80ee59fd86306c7433b3df100b32499b4e3b Gerrit-Change-Number: 19546 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-CC: Jenkins <[email protected]> Gerrit-CC: Michael Blow <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Mon, 24 Mar 2025 12:15:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
