>From <preethampolupar...@gmail.com>: Attention is currently required from: murali.kris...@couchbase.com. preethampolupar...@gmail.com has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19608 )
Change subject: [ASTERIXDB-3589][COMP] replace complex join predicate with expressions ...................................................................... Patch Set 2: (1 comment) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinEnum.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19608/comment/b2fe1903_2adaa2b7 PS2, Line 504: if (usedVars.contains(aOp.getVariables().get(i))) { It looks like the AssignOperator is being removed even if only one of its variables has a replacement. Shouldn't we retain it unless all variables are being replaced? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19608 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I355943fbf65fa0879b8a1e1827f6a4405997b05b Gerrit-Change-Number: 19608 Gerrit-PatchSet: 2 Gerrit-Owner: murali.kris...@couchbase.com Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: murali.kris...@couchbase.com Gerrit-CC: preethampolupar...@gmail.com Gerrit-Attention: murali.kris...@couchbase.com Gerrit-Comment-Date: Fri, 04 Apr 2025 09:04:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
