>From Michael Blow <mb...@apache.org>: Attention is currently required from: preethampolupar...@gmail.com, Hussain Towaileb. Michael Blow has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19562 )
Change subject: [NO ISSUE][EXT]: Fail early in COPY TO if no write permissin ...................................................................... Patch Set 4: (5 comments) Commit Message: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19562/comment/cbd8b811_4062e3c3 PS4, Line 7: permissin permission https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19562/comment/98ead9b0_16493814 PS4, Line 15: correctly check for bucket not found exception where? it looks like you just stopped checking for it, and now will just throw a generic sink error File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/writer/GCSExternalFileWriterFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19562/comment/27b110e1_4254d552 PS4, Line 72: Throwable why make this return Throwable when it will always return BaseServiceException? File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/writer/S3ExternalFileWriterFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19562/comment/2bd3e2bc_c1a29c2b PS4, Line 72: Throwable Why make this return Throwable when it will always return SdkException? Consider using a generic on the interface for use here, which would make the API cleaner I think... File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/ExceptionUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19562/comment/c80d5580_52df6262 PS4, Line 235: T might not be bad to consider using Optional<T> here to make it easier for callers to use correctly. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19562 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I954a60004f104aea4787075a94a069daca305fde Gerrit-Change-Number: 19562 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb <hussai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <hussai...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: preethampolupar...@gmail.com Gerrit-Attention: preethampolupar...@gmail.com Gerrit-Attention: Hussain Towaileb <hussai...@gmail.com> Gerrit-Comment-Date: Fri, 04 Apr 2025 11:27:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
