>From Murtadha Hubail <[email protected]>: Attention is currently required from: [email protected], Ritik Raj. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19637 )
Change subject: [ASTERIXDB-3596][STO] Fix double comparison in range filters ...................................................................... Patch Set 2: (1 comment) File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/filter/range/compartor/GEColumnFilterEvaluatorFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19637/comment/9eb30da1_d9256b0a PS2, Line 40: if (left.getTypeTag() != right.getTypeTag()) { : throw new IllegalStateException("Cannot compare different types %s and %s" : .formatted(left.getTypeTag(), right.getTypeTag())); : } We probably don't need this, but if you'd like to keep it, then we should do this check only once in AbstractComparator construct -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19637 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I64ebbfe3852e3521d6238314d1fe59dfd3695708 Gerrit-Change-Number: 19637 Gerrit-PatchSet: 2 Gerrit-Owner: [email protected] Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Ritik Raj <[email protected]> Gerrit-CC: Anon. E. Moose #1000171 Gerrit-CC: Murtadha Hubail <[email protected]> Gerrit-Attention: [email protected] Gerrit-Attention: Ritik Raj <[email protected]> Gerrit-Comment-Date: Fri, 11 Apr 2025 11:07:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
