>From Peeyush Gupta <[email protected]>: Attention is currently required from: Murtadha Hubail. Peeyush Gupta has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19730 )
Change subject: [ASTERIXDB-3603][FUN] Adding validation for transform functions ...................................................................... Patch Set 4: (3 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/visitor/FunctionCardinalityInferenceVisitor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19730/comment/b7e1d07f_55349c11 PS4, Line 49: op.getMaxObjects() > Don't we need to check if hasMaxObjects()? I think this will happen if you > only have OFFSET without […] Ack File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/function/transform/positive/transform.001.ddl.sqlpp: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19730/comment/235b21c5_5bb16610 PS4, Line 21: -- Fail: More than one argument > I believe this is type, right? (same thing for the other ones in this > positive test case) Ack https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19730/comment/88ec914c_24da95fa PS4, Line 24: SELECT count(*) as count FROM [doc] t UNNEST t.a > We can add one more test (whether negative or positive) that does GROUP BY t. > […] Ack -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19730 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I524cbfb6685bd3c7ed269c2db48482e5aba1ce6c Gerrit-Change-Number: 19730 Gerrit-PatchSet: 4 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Comment-Date: Fri, 09 May 2025 17:27:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ali Alsuliman <[email protected]> Gerrit-MessageType: comment
