>From Ali Alsuliman <[email protected]>: Attention is currently required from: Peeyush Gupta. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19744 )
Change subject: [ASTERIXDB-3603][FUN] Runtime changes for transform functions ...................................................................... Patch Set 5: (2 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19744/comment/1433adbc_221fe67d PS5, Line 513: LogicalVariable unnestVar = getUnnestVar(topOp); minor thing; we can add a little comment here about the purpose since it may not be that clear. File hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/base/AbstractOneInputOneOutputOneFramePushRuntime.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19744/comment/b8d5f132_af70a7bc PS5, Line 72: if (closeException != null) Do we need to ignore also here and not throw? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19744 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0b23d88db632d90aedec409db816c66a5a688daf Gerrit-Change-Number: 19744 Gerrit-PatchSet: 5 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Ali Alsuliman <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Comment-Date: Fri, 30 May 2025 01:24:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
