>From Peeyush Gupta <[email protected]>:

Attention is currently required from: Janhavi Tripurwar.
Peeyush Gupta has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19828 )

Change subject: [ASTERIXDB-3615][FUN]: lpad and rpad func
......................................................................


Patch Set 10:

(1 comment)

File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringPadEvaluator.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19828/comment/4fb11e39_b0a66415
PS10, Line 117: inStrCodePointsNum == targetNumCodePoints
there was a check or padding length being 0. we should not have removed that. 
following gives an exception now
select lpad('hgjgjgj', 56, '');



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19828
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: ionic
Gerrit-Change-Id: Ia74279fbbe9d23538c057cbbae9538cb219da1f2
Gerrit-Change-Number: 19828
Gerrit-PatchSet: 10
Gerrit-Owner: Janhavi Tripurwar <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Janhavi Tripurwar <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Peeyush Gupta <[email protected]>
Gerrit-Attention: Janhavi Tripurwar <[email protected]>
Gerrit-Comment-Date: Sat, 31 May 2025 05:22:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to