Taewoo Kim has posted comments on this change. Change subject: Index-only plan step 3: Top-down Select and Join transformation rule ......................................................................
Patch Set 45: (6 comments) Thanks Yingyi. https://asterix-gerrit.ics.uci.edu/#/c/1350/45/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java: PS45, Line 389: > Can we separate the function into two: I see what you mean. I have checked the code thoroughly. The update part happens at the end of the analyze() function. So, I refactored the code so that the update part is now a separate function. However, for this method, since the update actually happens in the deep inside and this is just a gate. https://asterix-gerrit.ics.uci.edu/#/c/1350/46/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodAnalysisContext.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodAnalysisContext.java: PS46, Line 85: > > Wrap a get and a put method and encapsulate the map so that we can easily t Done PS46, Line 89: setIndexDatasetMap > This method is not called. Done https://asterix-gerrit.ics.uci.edu/#/c/1350/46/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java: PS46, Line 87: isLeftOuterJoin > Now since you're doing top-down traversal, do you still need those states? You are right. This variable can be removed. I have changed the code. PS46, Line 104: Override > should you implement rewritePre(...) if you're doing top-down traversal? Done https://asterix-gerrit.ics.uci.edu/#/c/1350/46/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java: PS46, Line 105: public boolean rewritePost(Mutable<ILogicalOperator> opRef, IOptimizationContext context) > Should you use rewritePre(...) if you're doing top-down traversal? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1350 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60a2a61eb46851d4c16c8f17447e3ac9b0aca779 Gerrit-PatchSet: 45 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <wangs...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Taewoo Kim <wangs...@gmail.com> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-HasComments: Yes