>From Murtadha Hubail <[email protected]>: Attention is currently required from: Peeyush Gupta, Ali Alsuliman, Michael Blow, Hussain Towaileb. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19954 )
Change subject: [ASTERIXDB-3623][OTH] Wait for submitted cloud requests on exceeding max pending HTTP connections ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/S3ParallelDownloader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19954/comment/530205e5_30690924 PS2, Line 129: if (maxPending > 0 && downloads.size() >= maxPending) { : waitForFileDownloads(downloads); : downloads.clear(); : } > Just for future improvement (based on the review of code by chat gpt). […] Indeed. Good thing is that we use AWS CRT on AWS S3 deployments. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19954 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ifd1a30c6eed5f316a2d7a17b685f537c24e6c0d2 Gerrit-Change-Number: 19954 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Mon, 23 Jun 2025 14:59:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Peeyush Gupta <[email protected]> Gerrit-MessageType: comment
