Yingyi Bu has posted comments on this change. Change subject: Let SPLIT operator work as expected ......................................................................
Patch Set 2: (9 comments) https://asterix-gerrit.ics.uci.edu/#/c/1542/2/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/SplitOperator.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/SplitOperator.java: PS2, Line 36: defaultBranchForMissingExprValue The variable name seems confusing. Missing has another meaning in the data model, i.e., missing Values. private final int defaultBranch; PS2, Line 39: propageToAllBranchForMissingExprValue The variable name seems confusing. Missing has another meaning in the data model, i.e., missing Values. private final boolean propagateToAllBranchAsDefault; PS2, Line 43: call this(...) instead of doing each individual assignments. PS2, Line 70: getDefaultBranchForMissingExprValue Update the method name accordingly? PS2, Line 74: getPropageToAllBranchForMissingExprValue Update the method name accordingly? https://asterix-gerrit.ics.uci.edu/#/c/1542/2/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java: Line 240: case SPLIT: { > MAJOR SonarQube violation: fix this. In addition, it seems you need a "break" here. https://asterix-gerrit.ics.uci.edu/#/c/1542/2/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/SplitOperatorDescriptor.java File hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/SplitOperatorDescriptor.java: PS2, Line 59: rDesc call this(....) instead of doing each individual assignments? PS2, Line 128: 1 int outBranch = defaultBranchForMissingExprValue? PS2, Line 153: defaultBranchForMissingExprValue it seems you don't need this extra assignment? -- To view, visit https://asterix-gerrit.ics.uci.edu/1542 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I999288ea4cf286e34d735a840843bf161876d3e3 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
