>From Ali Alsuliman <ali.al.solai...@gmail.com>: Attention is currently required from: Peeyush Gupta. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20010 )
Change subject: [NO ISSUE][COMP] Remove check-unknown for Insert/Upsert on datasets with meta part ...................................................................... Patch Set 1: (2 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20010/comment/ae6ec233_f66353cb PS1, Line 169: op instanceof InsertDeleteUpsertOperator Typically, we use getOperatorTag() == LogicalOperatorTag.INSERT_DELETE_UPSERT https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20010/comment/97d5b723_a09484ab PS1, Line 172: checkUnknown = false; Just checking; there are other paths similar to this: IntroduceAutogenerateIDRule IntroduceStaticTypeCastForInsertRule Did we check if ingestion (or hasMetaPart) can go through them? If yes, we probably have to do the same thing over there. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20010 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I55766c9a334f40efd996e2b453f7237aec739966 Gerrit-Change-Number: 20010 Gerrit-PatchSet: 1 Gerrit-Owner: Peeyush Gupta <peeyush.gu...@couchbase.com> Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Peeyush Gupta <peeyush.gu...@couchbase.com> Gerrit-Attention: Peeyush Gupta <peeyush.gu...@couchbase.com> Gerrit-Comment-Date: Wed, 02 Jul 2025 22:44:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
