>From Ritik Raj <ritik....@couchbase.com>: Attention is currently required from: Peeyush Gupta. Ritik Raj has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20016 )
Change subject: [ASTERIXDB-3601][STO] Unpinning the not required segmentPages ...................................................................... Patch Set 3: (3 comments) File asterixdb/asterix-app/pom.xml: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20016/comment/1e54c5f7_8badea47 PS3, Line 494: CloudStorageSparseTest > Do you need to include the complete CloudStorageSparseTest. […] I am not sure, just checked where CloudStorageTest was being used, and added CloudStorageSparseTest there. File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/zero/PageZeroWriterFlavorSelector.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20016/comment/9748080a_26dfe4bc PS3, Line 53: DEFAULT > Any particular reason for this change? yes, in case of "adaptive" mode, if there is a batch end just after the first tuple, then the writerFlag is not set to sparse or default based on the adaptiveness, it still remains -1, which fails to initialise the pageZeroWriter. So, In those cases it will pick DefaultPageZeroWriter. Now, I think, I can keep it ADAPTIVE, and calculate the layout for just 1 record; File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree-column/src/main/java/org/apache/hyracks/storage/am/lsm/btree/column/cloud/ColumnRanges.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20016/comment/3e1f2e33_63b5b708 PS3, Line 171: leafFrame.unPinNotRequiredPageZeroSegments(); > Can explicit unpinning here cause any issues when a query is running > concurrenlty? BufferCache should be managing this, if queries are trying to unpin concurrently. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20016 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I915031e39a17ac853a24d78809b7742e2ea60163 Gerrit-Change-Number: 20016 Gerrit-PatchSet: 3 Gerrit-Owner: Ritik Raj <ritik....@couchbase.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Peeyush Gupta <peeyush.gu...@couchbase.com> Gerrit-Attention: Peeyush Gupta <peeyush.gu...@couchbase.com> Gerrit-Comment-Date: Mon, 07 Jul 2025 19:50:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peeyush Gupta <peeyush.gu...@couchbase.com> Gerrit-MessageType: comment
