>From Ali Alsuliman <[email protected]>: Attention is currently required from: Shahrzad Shirazi. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20004 )
Change subject: [NO ISSUE][COMP] Change plan to show RETAIN-UNTRUE for null placeholders ...................................................................... Patch Set 7: (7 comments) Commit Message: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20004/comment/f6fe2eb1_288caea7 PS7, Line 16: Let's use Ext-ref: MB-67347 File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20004/comment/51ed93c8_8ecddf8d PS7, Line 786: Object Use IAlgebricksConstantValue https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20004/comment/b7bb1817_9d2571fd PS7, Line 787: jsonGenerator.writeObjectFieldStart("retain-missing"); Remove this https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20004/comment/b66bb5f9_6147093b PS7, Line 790: placeholder Make this "retain-untrue-variable" https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20004/comment/97248f9c_764a1607 PS7, Line 792: if (retainValue != null) { Remove this "if" since we know retainValue is never null here. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20004/comment/926e06b0_6fe3df03 PS7, Line 793: value Make this "retain-untrue-value" https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20004/comment/2fc80e31_1937a4e3 PS7, Line 796: jsonGenerator.writeEndObject(); Remove this -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20004 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I4a3af98be2cf74e837222755abfd45a075b3b257 Gerrit-Change-Number: 20004 Gerrit-PatchSet: 7 Gerrit-Owner: Shahrzad Shirazi <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Shahrzad Shirazi <[email protected]> Gerrit-Attention: Shahrzad Shirazi <[email protected]> Gerrit-Comment-Date: Fri, 18 Jul 2025 02:51:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
