>From Ian Maxon <ima...@apache.org>:
Attention is currently required from: Ian Maxon.
Hello Ali Alsuliman, Jenkins, Anon. E. Moose #1000171,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20069
to look at the new patch set (#8).
Change subject: [ASTERIXDB-3628][RT] Correct subplan profiles
......................................................................
[ASTERIXDB-3628][RT] Correct subplan profiles
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
Currently subplan timing information is calculated during close().
This can lead to inaccuracies in the timing, especially when the
subplan is near the end of a task pipeline, because other
operator's times are calculated after close, during deinitialize().
Correct this by adding the capability in the MetaOperator to invoke a
method on each ProfiledPushRuntime SubplanPushRuntime to calculate the
timings, so it can be invoked at the proper time as to retrieve the
correct time from its downstream operators.
Ext-ref: MB-67499
Change-Id: I4d38710626778ef52abb1cd4fe1e0b26e0d74bec
---
A
asterixdb/asterix-app/src/test/resources/runtimets/results/profile/subplan/subplan.3.regex
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/ProfiledOperatorNodePushable.java
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/profile/subplan/subplan.1.ddl.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/profile/subplan/subplan.2.update.sqlpp
A
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/base/IProfiledPushRuntime.java
A
asterixdb/asterix-app/src/test/resources/runtimets/results/profile/subplan/subplan.5.regex
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/profile/subplan/subplan.3.plans.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/profile/subplan/subplan.4.plans.sqlpp
M
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/SubplanRuntimeFactory.java
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/profile/subplan/subplan.5.plans.sqlpp
M
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/base/ProfiledPushRuntime.java
M
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/PipelineAssembler.java
A
asterixdb/asterix-app/src/test/resources/runtimets/results/profile/subplan/subplan.4.regex
M
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/AlgebricksMetaOperatorDescriptor.java
M asterixdb/asterix-app/src/test/resources/runtimets/profiled.xml
15 files changed, 248 insertions(+), 11 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/69/20069/8
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20069
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: ionic
Gerrit-Change-Id: I4d38710626778ef52abb1cd4fe1e0b26e0d74bec
Gerrit-Change-Number: 20069
Gerrit-PatchSet: 8
Gerrit-Owner: Ian Maxon <ima...@apache.org>
Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon <ima...@apache.org>
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Attention: Ian Maxon <ima...@apache.org>
Gerrit-MessageType: newpatchset
