>From Preetham Poluparthi <preetha...@apache.org>: Attention is currently required from: Murtadha Hubail, Peeyush Gupta, Hussain Towaileb. Preetham Poluparthi has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20029 )
Change subject: [ASTERIXDB-3392] Handle NULL/Empty types in Copy to parquet ...................................................................... Patch Set 10: Code-Review+1 (3 comments) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/parquet/SchemaCheckerLazyVisitor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20029/comment/0eee9938_3f74ccb3 PS8, Line 62: if (recordType.getChildren().size() != pointable.getNumberOfChildren()) { remove this https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20029/comment/d570d8b4_a4a52654 PS8, Line 122: if(pointable.getTypeTag()==ATypeTag.NULL){ SchemaNode.getTypeTag should never be MISSING https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20029/comment/f6670b36_2ba470bb PS8, Line 135: if(flatType.isStrictChildOf(pointable.getTypeTag())) { rename flattype to inferrred , pointable to new value -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20029 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I79af2b66200063b6d09fe0cd2dfda3d9e7939925 Gerrit-Change-Number: 20029 Gerrit-PatchSet: 10 Gerrit-Owner: Preetham Poluparthi <preetha...@apache.org> Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <hussai...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Peeyush Gupta <peeyush.gu...@couchbase.com> Gerrit-Reviewer: Preetham Poluparthi <preetha...@apache.org> Gerrit-Attention: Murtadha Hubail <mhub...@apache.org> Gerrit-Attention: Peeyush Gupta <peeyush.gu...@couchbase.com> Gerrit-Attention: Hussain Towaileb <hussai...@gmail.com> Gerrit-Comment-Date: Sat, 26 Jul 2025 18:50:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
