>From Shahrzad Shirazi <shaji...@ucr.edu>: Attention is currently required from: Ali Alsuliman, Michael Blow, Hussain Towaileb. Shahrzad Shirazi has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146 )
Change subject: [NO ISSUE][COMP] Add None as quote option for CSV in external collections ...................................................................... Patch Set 12: (4 comments) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/QuotedLineRecordReader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146/comment/b6cd2f20_f332c026 PS12, Line 62: this.quoteCheckNeeded = this.quote != CSVUtils.NULL_CHAR; > Should not this be driven by checking against "NONE" value in the config? > i.e. […] There is a possibility that someone has quote as '\0'. Will take this to the config in the new patchset. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146/comment/3ea8f0e7_5ef90844 PS12, Line 93: public boolean hasNext() throws IOException { > Shouldn't we just call super. […] Yes, I just checked it, that would be a better option. I had tried to do the same thing here by reimplementing it, but there is no need as you said,thanks. will change in the new patch set. File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146/comment/242ad7b1_49edf08d PS12, Line 698: public static void validateChar > This is a common path for other parameters too. […] Got it, thanks, will change in the new patch set. File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/file/FieldCursorForDelimitedDataParser.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146/comment/8bd516c7_64068e1f PS12, Line 215: if (ch == '\n' && !startedQuote) { > Isn't this going to fail when we encounter '\n' at the end of the line since > !startedQuote is always […] I see, will work on it and add more test cases to make sure it is fine. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I3812d2d1306282e9f02e8b77e1f79ac6b203cabe Gerrit-Change-Number: 20146 Gerrit-PatchSet: 12 Gerrit-Owner: Shahrzad Shirazi <shaji...@ucr.edu> Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <hussai...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org> Gerrit-Attention: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Attention: Michael Blow <mb...@apache.org> Gerrit-Attention: Hussain Towaileb <hussai...@gmail.com> Gerrit-Comment-Date: Fri, 01 Aug 2025 21:48:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-MessageType: comment
