Till Westmann has posted comments on this change.

Change subject: Fix local clsuter stop and erase scripts.
......................................................................


Patch Set 3:

(6 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1549/3//COMMIT_MSG
Commit Message:

PS3, Line 7: clsuter
s/clsuter/cluster/


PS3, Line 9: ;
no semicolon?


PS3, Line 10: ;
no semicolon?


PS3, Line 12: earsed
s/earsed/erased/


https://asterix-gerrit.ics.uci.edu/#/c/1549/3/asterixdb/asterix-server/src/main/opt/ansible/yaml/instance_stop.yml
File asterixdb/asterix-server/src/main/opt/ansible/yaml/instance_stop.yml:

PS3, Line 23: egrep
Since we anyway need awk and awk does nice regex matching should we just use 
awk, e.g.

    ps aux | awk '/[j]ava.*(CDriver|NCService)/'

The challenge might be, that awk doesn't fail if no lines are matched. If we 
need that things are more complicated ...

    ps aux | awk '/[j]ava.*(CDriver|NCService)/ {fnd=1} END {exit 1-fnd}'


PS3, Line 31: awk
Here just using awk make things quite a bit more compact:

    ps aux | awk '/[j]ava.*(CDriver|NCService)/ {print $2}'


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1549
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib62483bfbb08ebd6f3ed97d1b64645541ce19d35
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-HasComments: Yes

Reply via email to