>From Ali Alsuliman <ali.al.solai...@gmail.com>: Attention is currently required from: Peeyush Gupta, Preetham Poluparthi. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19763 )
Change subject: [ASTERIXDB-3632]: Add Index Advisor ...................................................................... Patch Set 36: (6 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/indexadvisor/FakeIndexProvider.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19763/comment/ba7e9a60_881d9b10 PS36, Line 68: dataSource Why not use dataSource.getDataset().getDatasetFullyQualifiedName()? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19763/comment/29aa2b1e_5effe051 PS36, Line 103: filterIndexesMap.get(qualifiedName) Can't you use the value that you just put above? e.g.: Map<> datasetIndexes = new HashMap<>(); filterIndexesMap.put(qualifiedName, datasetIndexes); ... datasetIndexes.put(primaryKeyName, primIndex); This way you don't have to look up filterIndexesMap again and inside the while loop. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19763/comment/5ad1e386_2c3b4540 PS36, Line 144: filterIndexesMap.get(qualifiedName) Move this filterIndexesMap.get(qualifiedName) just above the while loop and use inside. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19763/comment/eeaa1444_616fabcb PS36, Line 158: dataSource.getId().getDatabaseName(); Why not use dataSource.getDataset().getDatasetFullyQualifiedName()? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19763/comment/40bccc9b_8c40dd2f PS36, Line 162: joinDataSourceFieldNamesMap.putIfAbsent(qualifiedName,new HashSet<>()); Do it like this: joinDataSourceFieldNamesMap.computeIfAbsent(qualifiedName,k -> new HashSet<>()).add(fields); File asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/Query.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19763/comment/d40a39ef_d0169116 PS36, Line 118: advise How about the equals() method? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19763 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: phoenix Gerrit-Change-Id: Iac773ebb49bdde18cfd340ef15d483dc324bdced Gerrit-Change-Number: 19763 Gerrit-PatchSet: 36 Gerrit-Owner: Preetham Poluparthi <preetha...@apache.org> Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Peeyush Gupta <peeyush.gu...@couchbase.com> Gerrit-Reviewer: Preetham Poluparthi <preetha...@apache.org> Gerrit-Attention: Peeyush Gupta <peeyush.gu...@couchbase.com> Gerrit-Attention: Preetham Poluparthi <preetha...@apache.org> Gerrit-Comment-Date: Fri, 22 Aug 2025 02:10:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
