>From Preetham Poluparthi <preetha...@apache.org>: Attention is currently required from: Peeyush Gupta, Ali Alsuliman. Preetham Poluparthi has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19763 )
Change subject: [ASTERIXDB-3632]: Add Index Advisor ...................................................................... Patch Set 37: (7 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/indexadvisor/AdvisorConditionParser.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19763/comment/9cb0871c_9b30fabc PS36, Line 208: if(expr.getArguments().size()!=2) {return null;} > Formatting issues Done File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/indexadvisor/FakeIndexProvider.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19763/comment/56437c71_48f471e3 PS36, Line 68: dataSource > Why not use dataSource.getDataset(). […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19763/comment/7e21ca61_169a6b7d PS36, Line 103: filterIndexesMap.get(qualifiedName) > Can't you use the value that you just put above? e.g.: […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19763/comment/709d1aa4_395fac56 PS36, Line 144: filterIndexesMap.get(qualifiedName) > Move this filterIndexesMap.get(qualifiedName) just above the while loop and > use inside. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19763/comment/42cd36dd_10079330 PS36, Line 158: dataSource.getId().getDatabaseName(); > Why not use dataSource.getDataset(). […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19763/comment/04b329e5_00069bf1 PS36, Line 162: joinDataSourceFieldNamesMap.putIfAbsent(qualifiedName,new HashSet<>()); > Do it like this: […] Done File asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/Query.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19763/comment/31af1d26_cb7acbeb PS36, Line 118: advise > How about the equals() method? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19763 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Iac773ebb49bdde18cfd340ef15d483dc324bdced Gerrit-Change-Number: 19763 Gerrit-PatchSet: 37 Gerrit-Owner: Preetham Poluparthi <preetha...@apache.org> Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Peeyush Gupta <peeyush.gu...@couchbase.com> Gerrit-Reviewer: Preetham Poluparthi <preetha...@apache.org> Gerrit-Attention: Peeyush Gupta <peeyush.gu...@couchbase.com> Gerrit-Attention: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Comment-Date: Fri, 22 Aug 2025 08:25:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-MessageType: comment
