>From Peeyush Gupta <peeyush.gu...@couchbase.com>:

Attention is currently required from: Ali Alsuliman, Michael Blow.
Peeyush Gupta has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20135 )

Change subject: [ASTERIXDB-3633][EXT] Support file splits while reading delta 
tables
......................................................................


Patch Set 10:

(1 comment)

File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/aws/delta/DeltaReaderFactory.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20135/comment/c5a2c967_67d59269
PS7, Line 192: FileSplit
> Doesn't need to be an anonymous class, couldn't you update 
> SerializableFileSplit to extend this File […]
Updated SerializableFileSplit to extend FileSplit that made the code simpler. 
Although, I still had to use FileSplit's writable interface to avoid Java's own 
serialization.



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20135
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: ionic
Gerrit-Change-Id: Ie6daf3846064326bfe749ad15b508fe27d1721ca
Gerrit-Change-Number: 20135
Gerrit-PatchSet: 10
Gerrit-Owner: Peeyush Gupta <peeyush.gu...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Peeyush Gupta <peeyush.gu...@couchbase.com>
Gerrit-CC: Michael Blow <mb...@apache.org>
Gerrit-Attention: Ali Alsuliman <ali.al.solai...@gmail.com>
Gerrit-Attention: Michael Blow <mb...@apache.org>
Gerrit-Comment-Date: Wed, 27 Aug 2025 02:53:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peeyush Gupta <peeyush.gu...@couchbase.com>
Comment-In-Reply-To: Michael Blow <mb...@apache.org>
Gerrit-MessageType: comment

Reply via email to