>From Ritik Raj <ritik....@couchbase.com>: Attention is currently required from: Murtadha Hubail. Ritik Raj has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20283 )
Change subject: [ASTERIXDB-3636][STO] Fix buffer reservations understimation ...................................................................... Patch Set 8: (8 comments) Commit Message: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20283/comment/7fb7bb96_b43a8f04 PS7, Line 11: no > yes Done File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/bytes/encoder/AbstractParquetDeltaBinaryPackingValuesWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20283/comment/88f7bd22_89921013 PS7, Line 41: // 1 for temporary buffers > so true Done File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/operation/lsm/flush/NoWriteFlushColumnMetadata.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20283/comment/6b572d08_97447785 PS7, Line 69: bufferRequiredByCurrentTuple > buffersRequiredByCurrentTuple Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20283/comment/8ac47401_4283774c PS7, Line 210: getBufferRequiredByWriter > getBuffersRequiredByWriter Done File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/IColumnValuesWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20283/comment/92994e99_b9b20a87 PS7, Line 141: requiredTemporaryBuffersCount > getRequiredTemporaryBuffersCount Done File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/writer/BooleanColumnValuesWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20283/comment/8405e0e8_f5ca94d6 PS7, Line 95: 0 > if you indeed need both methods, at least call the static from this one if > they are identical Done File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20283/comment/c9124d40_fa217881 PS6, Line 83: return 5.0d; > Let's go with 50% for small JVMs in the hopes that no current queries are > running while ingestion is […] Done File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/ColumnBufferPool.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20283/comment/c09e5805_0ccf052d PS7, Line 46: buffersAllocated > do you really need this or can you reuse some existing variable to do this > check? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20283 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I3bfb9e9ac4b908ee2e7d84cab4781f6e0f7444e8 Gerrit-Change-Number: 20283 Gerrit-PatchSet: 8 Gerrit-Owner: Ritik Raj <ritik....@couchbase.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org> Gerrit-Attention: Murtadha Hubail <mhub...@apache.org> Gerrit-Comment-Date: Mon, 01 Sep 2025 15:39:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Murtadha Hubail <mhub...@apache.org> Comment-In-Reply-To: Ritik Raj <ritik....@couchbase.com> Gerrit-MessageType: comment
