>From Michael Blow <mb...@apache.org>:

Attention is currently required from: Ian Maxon.

Michael Blow has posted comments on this change by Ian Maxon. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20280?usp=email )

Change subject: [ASTERIXDB-3640][TEST]Use s3mock in testcontainers
......................................................................


Patch Set 15:

(1 comment)

File 
asterixdb/asterix-app/src/test/java/org/apache/asterix/api/common/LocalCloudUtilAdobeMock.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20280/comment/05f0674a_db8a1c43?usp=email
 :
PS15, Line 93:         URI endpoint = URI.create(s3Mock.getHttpEndpoint()); // 
endpoint pointing to S3 mock server
thank you for this- it grinds my gears when we force containers to map to 
specific ports on the host :facepalm:



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20280?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: asterixdb
Gerrit-Branch: phoenix
Gerrit-Change-Id: Iad1a6f9331fd844f3e3c04b8f56e811e4117f83a
Gerrit-Change-Number: 20280
Gerrit-PatchSet: 15
Gerrit-Owner: Ian Maxon <ima...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-CC: Michael Blow <mb...@apache.org>
Gerrit-Attention: Ian Maxon <ima...@apache.org>
Gerrit-Comment-Date: Fri, 19 Sep 2025 00:07:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to