Yingyi Bu has posted comments on this change. Change subject: Cleanup and bug fixes in Feeds pipeline ......................................................................
Patch Set 12: (15 comments) https://asterix-gerrit.ics.uci.edu/#/c/1523/12/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ExceptionUtils.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ExceptionUtils.java: PS12, Line 40: HyracksDataException return HyracksDataException.create(th); https://asterix-gerrit.ics.uci.edu/#/c/1523/12/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java: PS12, Line 186: /** Make the comments more complete? E.g., used in what kind of scenarios in extension. https://asterix-gerrit.ics.uci.edu/#/c/1523/12/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java: PS12, Line 365: this What does this comment mean? https://asterix-gerrit.ics.uci.edu/#/c/1523/12/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/runtime/CommitRuntime.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/runtime/CommitRuntime.java: PS12, Line 114: this open an issue? https://asterix-gerrit.ics.uci.edu/#/c/1523/12/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/api/AbstractPointable.java File hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/api/AbstractPointable.java: PS12, Line 33: return comment on the parameter and return. PS12, Line 36: arraycopy boundary/length check of copy? https://asterix-gerrit.ics.uci.edu/#/c/1523/12/hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/io/MessagingFrameTupleAppender.java File hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/io/MessagingFrameTupleAppender.java: PS12, Line 46: protected Can we implement ProgressFrameTupleAppender as a separate FrameTupleAppender? It looks that few things are common and does not seem to be an inheritance relationship. The data coupling caused by those protected fields make the code of ProgressFrameTupleAppender difficult to read. https://asterix-gerrit.ics.uci.edu/#/c/1523/12/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/connectors/PartitionDataWriter.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/connectors/PartitionDataWriter.java: PS12, Line 42: protected Can we implement ProgressPartitionDataWriter as a separate IFrameWriter, rather than an inherited class from PartitionDataWriter. It looks very few things are common between them.. https://asterix-gerrit.ics.uci.edu/#/c/1523/12/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/IFrameOperationCallback.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/IFrameOperationCallback.java: PS12, Line 23: FunctionalInterface Comment the interface, i.e., why do we need the interface, what does it do, and when it is used etc.. PS12, Line 25: frameCompleted comment the interface method. https://asterix-gerrit.ics.uci.edu/#/c/1523/12/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/IFrameOperationCallbackFactory.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/IFrameOperationCallbackFactory.java: PS12, Line 26: IFrameOperationCallbackFactory comment the interface and its method. https://asterix-gerrit.ics.uci.edu/#/c/1523/12/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMHarness.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMHarness.java: PS12, Line 63: updateMeta java doc for the two interface methods. https://asterix-gerrit.ics.uci.edu/#/c/1523/12/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMIndexAccessor.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMIndexAccessor.java: PS12, Line 142: ( javadoc for the added methods. https://asterix-gerrit.ics.uci.edu/#/c/1523/12/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMTreeIndexAccessor.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMTreeIndexAccessor.java: PS12, Line 171: memory open an issue? PS12, Line 179: DELETE open an issue? -- To view, visit https://asterix-gerrit.ics.uci.edu/1523 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie97b2133ebecb7380cf0ba336e60ed714d06f8ee Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
