>From Hussain Towaileb <[email protected]>: Attention is currently required from: Murtadha Hubail.
Hussain Towaileb has posted comments on this change by Murtadha Hubail. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20496?usp=email ) Change subject: [NO ISSUE][RT] Respond to NC in case of unexpected failures ...................................................................... Patch Set 1: (1 comment) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20496/comment/57b181f9_deda7d3a?usp=email : PS1, Line 248: messageBroker.sendMessageQuietly(responseMsg, requestNodeId); What if the issue in sending was in the content of the response message but not the throwable itself, will this continue to fail to be sent? If so, does it make sense to have some generic message that we can create an instance of and pass it the encountered exception? This way we ensure the response will always arrive. However, not sure if this might have an effect on the receiving side, in case it has an expectation on what to receive, so might need to check that. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20496?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: phoenix Gerrit-Change-Id: I5ff53205d7cbb23c91a482b22165e1645247745f Gerrit-Change-Number: 20496 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Hussain Towaileb <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Comment-Date: Fri, 17 Oct 2025 15:58:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
